Skip to content

Use .NET10p3 SDK #18471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
May 20, 2025
Merged

Use .NET10p3 SDK #18471

merged 13 commits into from
May 20, 2025

Conversation

vzarytovskii
Copy link
Member

It's roughly this time of the year, when F# is switching to the new preview SDKs, to start testing BCL and CLR changes. Switching of the TFM usually happens around summer.

@vzarytovskii vzarytovskii requested a review from a team as a code owner April 11, 2025 15:31
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 11, 2025 •
edited
Loading

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@vzarytovskii vzarytovskii added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Apr 11, 2025
@vzarytovskii
Copy link
Member Author

vzarytovskii commented Apr 11, 2025 •
edited
Loading

Hm, some source build (presumably) issues, I can fix them, please ping me next week.

@T-Gro
Copy link
Member

T-Gro commented Apr 28, 2025

@vzarytovskii : Ping, do you have an ideas what caused it?

@vzarytovskii
Copy link
Member Author

Judging by the plain builds working fine, some arcade shenanigans. I've updated on top of main, let me see what fails and how can I fix it.

@vzarytovskii
Copy link
Member Author

@ViktorHofer @baronfel getting a bunch of following by just upgrading SDK to 10p3:

D:\a\_work\1\s\tests\fsharp\FSharpSuite.Tests.fsproj : error NU1510: PackageReference System.Memory will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. [D:\a\_work\1\s\VisualFSharp.sln]
##[error]tests\fsharp\FSharpSuite.Tests.fsproj(0,0): error NU1510: (NETCORE_ENGINEERING_TELEMETRY=Restore) PackageReference System.Memory will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
D:\a\_work\1\s\tests\fsharp\FSharpSuite.Tests.fsproj : error NU1510: PackageReference System.Reflection.Metadata will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. [D:\a\_work\1\s\VisualFSharp.sln]
##[error]tests\fsharp\FSharpSuite.Tests.fsproj(0,0): error NU1510: (NETCORE_ENGINEERING_TELEMETRY=Restore) PackageReference System.Reflection.Metadata will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
  Restored D:\a\_work\1\s\tests\benchmarks\CompiledCodeBenchmarks\MicroPerf\MicroPerf.fsproj (in 541 ms).
  Restored D:\a\_work\1\s\tests\benchmarks\CompiledCodeBenchmarks\MicroPerf\CS\MicroPerfCSharp.csproj (in 2 ms).
D:\a\_work\1\s\tests\FSharp.Test.Utilities\FSharp.Test.Utilities.fsproj : error NU1510: PackageReference System.Collections.Immutable will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. [D:\a\_work\1\s\VisualFSharp.sln]
##[error]tests\FSharp.Test.Utilities\FSharp.Test.Utilities.fsproj(0,0): error NU1510: (NETCORE_ENGINEERING_TELEMETRY=Restore) PackageReference System.Collections.Immutable will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
D:\a\_work\1\s\tests\FSharp.Test.Utilities\FSharp.Test.Utilities.fsproj : error NU1510: PackageReference System.Memory will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. [D:\a\_work\1\s\VisualFSharp.sln]
##[error]tests\FSharp.Test.Utilities\FSharp.Test.Utilities.fsproj(0,0): error NU1510: (NETCORE_ENGINEERING_TELEMETRY=Restore) PackageReference System.Memory will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
D:\a\_work\1\s\tests\FSharp.Test.Utilities\FSharp.Test.Utilities.fsproj : error NU1510: PackageReference System.Buffers will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. [D:\a\_work\1\s\VisualFSharp.sln]
##[error]tests\FSharp.Test.Utilities\FSharp.Test.Utilities.fsproj(0,0): error NU1510: (NETCORE_ENGINEERING_TELEMETRY=Restore) PackageReference System.Buffers will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary.
D:\a\_work\1\s\tests\FSharp.Test.Utilities\FSharp.Test.Utilities.fsproj : error NU1510: PackageReference System.Diagnostics.DiagnosticSource will not be pruned. Consider removing this package from your dependencies, as it is likely unnecessary. [D:\a\_work\1\s\VisualFSharp.sln]

I haven't seen it before, does this ring a bell by any chance?

@ViktorHofer
Copy link
Member

Heyho. This is a new NuGet feature in the .NET 10 SDK. See https://learn.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#how-prunepackagereference-works for more details.

The gist is that the package references that are already provided by the shared frameworks used (usually Microsoft.NETCore.App) are unnecessary and should be removed. I.e. System.Text.Json is already provided inbox on .NETCoreApp TFMs.

@ViktorHofer
Copy link
Member

cc @nkolev92 @ericstj - looks like the warning is still creating confusion

@vzarytovskii
Copy link
Member Author

Heyho. This is a new NuGet feature in the .NET 10 SDK. See https://learn.microsoft.com/en-us/nuget/consume-packages/package-references-in-project-files#how-prunepackagereference-works for more details.

The gist is that the package references that are already provided by the shared frameworks used (usually Microsoft.NETCore.App) are unnecessary and should be removed. I.e. System.Text.Json is already provided inbox on .NETCoreApp TFMs.

Thanks! Huh, good to know. How does it play together with netfx? If we build both core and desktop compilers? Or is it purely build-time feature (where to copy assemblies from?)?

@ViktorHofer
Copy link
Member

ViktorHofer commented Apr 28, 2025 •
edited
Loading

If we build both core and desktop compilers? Or is it purely build-time feature (where to copy assemblies from?)?

For multi-targeting projects you want to condition PackageReference items on the TFMs that need them.

@vzarytovskii
Copy link
Member Author

If we build both core and desktop compilers? Or is it purely build-time feature (where to copy assemblies from?)?

For multi-targeting projects you want to condition PackageReference items on the TFMs that need them.

Thanks. Btw, when conditionally aded the S.C.Immutable, got the following:

  FSharp.Compiler.Service netstandard2.0 succeeded with 4 warning(s) (48.9s) → artifacts/bin/FSharp.Compiler.Service/Release/netstandard2.0/FSharp.Compiler.Service.dll
    /Users/u/code/fsharp3/src/Compiler/Utilities/Activity.fs(96,19): warning FS3261: Nullness warning: The types 'ActivityDisposable' and 'IDisposable | null' do not have compatible nullability.
    /Users/u/code/fsharp3/src/Compiler/Utilities/Activity.fs(103,59): warning FS3261: Nullness warning: The types 'ActivityDisposable' and 'IDisposable | null' do not have compatible nullability.
    /Users/u/code/fsharp3/src/Compiler/Utilities/Activity.fs(130,83): warning FS3261: Nullness warning: The types 'ActivityDisposable' and 'IDisposable | null' do not have compatible nullability.
    /Users/u/code/fsharp3/src/Compiler/Utilities/Cancellable.fs(187,85): warning FS3261: Nullness warning: The types 'IDisposable' and ''a MaybeNull' do not have compatible nullability.
  FSharp.Compiler.Service net9.0 succeeded with 4 warning(s) (51.1s) → artifacts/bin/FSharp.Compiler.Service/Release/net9.0/FSharp.Compiler.Service.dll
    /Users/u/code/fsharp3/src/Compiler/Utilities/Activity.fs(96,19): warning FS3261: Nullness warning: The types 'ActivityDisposable' and 'IDisposable | null' do not have compatible nullability.
    /Users/u/code/fsharp3/src/Compiler/Utilities/Activity.fs(103,59): warning FS3261: Nullness warning: The types 'ActivityDisposable' and 'IDisposable | null' do not have compatible nullability.
    /Users/u/code/fsharp3/src/Compiler/Utilities/Activity.fs(130,83): warning FS3261: Nullness warning: The types 'ActivityDisposable' and 'IDisposable | null' do not have compatible nullability.
    /Users/u/code/fsharp3/src/Compiler/Utilities/Cancellable.fs(187,85): warning FS3261: Nullness warning: The types 'IDisposable' and ''a MaybeNull' do not have compatible nullability.
  fsc net9.0 succeeded (1.3s) → artifacts/bin/fsc/Release/net9.0/fsc.dll
  fsi net9.0 succeeded (1.7s) → artifacts/bin/fsi/Release/net9.0/fsi.dll
  FSharp.Test.Utilities net9.0 failed with 1 error(s) (4.0s)
    FSC : error FS0078: Unable to find the file '/lib/netstandard2.0/System.Collections.Immutable.dll' in any of /Users/u/code/fsharp3/tests/FSharp.Test.Utilities

Had to ignore the warning.

@vzarytovskii vzarytovskii requested a review from a team as a code owner April 28, 2025 14:59
@vzarytovskii
Copy link
Member Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command.

@vzarytovskii
Copy link
Member Author

bruh

@vzarytovskii vzarytovskii reopened this May 12, 2025
@T-Gro
Copy link
Member

T-Gro commented May 14, 2025

Lets see if NoWarn=NU1510 will make this work

@vzarytovskii
Copy link
Member Author

Hm, I am unsure why ilverify baselines changed...

@ViktorHofer
Copy link
Member

Should this also update the Arcade SDK in tandem or do you want to do that in a follow-up? When you do that, you can clean-up some infra: dotnet/dotnet#706

@vzarytovskii
Copy link
Member Author

Should this also update the Arcade SDK in tandem or do you want to do that in a follow-up? When you do that, you can clean-up some infra: dotnet/dotnet#706

Probably separately via the darc bump?

@T-Gro T-Gro enabled auto-merge (squash) May 20, 2025 08:46
@T-Gro T-Gro merged commit 0c94261 into dotnet:main May 20, 2025
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkolev92 nkolev92 nkolev92 left review comments

@ViktorHofer ViktorHofer ViktorHofer left review comments

@abonie abonie abonie approved these changes

@T-Gro T-Gro T-Gro approved these changes

Assignees
No one assigned
Labels
NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes
Projects
F# Compiler and Tooling
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vzarytovskii @T-Gro @ViktorHofer @nkolev92 @abonie